k-apol commented on PR #20326: URL: https://github.com/apache/kafka/pull/20326#issuecomment-3661874943
It's just to satisfy the error object contract On Tue, Dec 16, 2025, 11:45 AM Matthias J. Sax ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java > <https://github.com/apache/kafka/pull/20326#discussion_r2624191689>: > > > if (!topicsNotReady.isEmpty()) { > - final Set<NewTopic> newTopics = new HashSet<>(); > + maybeThrowTimeout(new TimeoutContext( > + Collections.singleton("makeReadyCheck"), // dummy collection just to trigger if `topicsNotReady` is non-empty > > @k-apol <https://github.com/k-apol> -- why do we pass in this dummy > instead of topicsNotReady ? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/kafka/pull/20326#pullrequestreview-3584266771>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BROWOLHK5HPY54DG6CZ6CYL4CBAKNAVCNFSM6AAAAACDNWOXOSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOBUGI3DMNZXGE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
