junrao commented on code in PR #19489:
URL: https://github.com/apache/kafka/pull/19489#discussion_r2628062038
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##########
@@ -2642,30 +2645,41 @@ public void testExpiredBatchDoesNotRetry() throws
Exception {
}
@Test
- public void testExpiredBatchDoesNotSplitOnMessageTooLargeError() throws
Exception {
- long deliverTimeoutMs = 1500L;
+ public void testBatchStillSplitOnMessageTooLargeError() throws Exception {
Review Comment:
testBatchStillSplitOnMessageTooLargeError =>
testExpiredBatchStillSplitOnMessageTooLargeError
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##########
@@ -2686,14 +2687,12 @@ public void testResetNextBatchExpiry() throws Exception
{
inOrder.verify(client, atLeastOnce()).newClientRequest(anyString(),
any(), anyLong(), anyBoolean(), anyInt(), any());
inOrder.verify(client, atLeastOnce()).send(any(), anyLong());
inOrder.verify(client).poll(eq(0L), anyLong());
- inOrder.verify(client).poll(eq(accumulator.getDeliveryTimeoutMs()),
anyLong());
Review Comment:
This comment still needs to be addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
