chia7712 commented on code in PR #21096:
URL: https://github.com/apache/kafka/pull/21096#discussion_r2629108165
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java:
##########
@@ -55,11 +55,11 @@ public ProducerStateEntry(long producerId, short
producerEpoch, int coordinatorE
firstBatchMetadata.ifPresent(batchMetadata::add);
Review Comment:
My original thought was that the handling of BatchMetadata should be
consistent between the constructor and addBatch. Perhaps a better cleanup would
be to remove the manual assignment logic in the constructor and simply call
addBatch explicitly
But I am also happy with just reverting the timestamp change for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
