shashankhs11 commented on code in PR #20292:
URL: https://github.com/apache/kafka/pull/20292#discussion_r2629447342
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -790,7 +792,13 @@ record = partitionGroup.nextRecord(recordInfo,
wallClockTime);
// after processing this record, if its partition queue's buffered
size has been
// decreased to the threshold, we can then resume the consumption
on this partition
- if (recordInfo.queue().size() <= maxBufferedSize) {
+ // TODO the second part of OR condition would be removed once
Review Comment:
addressed in cad0304
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -1130,7 +1138,9 @@ public void addRecords(final TopicPartition partition,
final Iterable<ConsumerRe
// if after adding these records, its partition queue's buffered size
has been
// increased beyond the threshold, we can then pause the consumption
for this partition
- if (newQueueSize > maxBufferedSize) {
+ // We do this only if the deprecated config
buffered.records.per.partition is set
+ if (maxBufferedSize != -1 && newQueueSize > maxBufferedSize) {
Review Comment:
addressed in cad0304
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java:
##########
@@ -249,12 +255,18 @@ StampedRecord nextRecord(final RecordInfo info, final
long wallClockTime) {
info.queue = queue;
if (queue != null) {
+
Review Comment:
addressed in cad0304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
