jiafu1115 commented on code in PR #20938:
URL: https://github.com/apache/kafka/pull/20938#discussion_r2636629968
##########
docs/documentation/zk2kraft.html:
##########
@@ -210,7 +210,7 @@ <h3 class="anchor-heading">Dynamic Controller
Configurations</h3>
--alter \
--add-config max.connections=10000
</code></pre><br/>
- It is not currently possible to apply a dynamic configuration
on only a single controller.
+ Prior to version 4.3, it was not possible to apply a dynamic
configuration on only a single dynamic controller.
Review Comment:
@chia7712 based on follow tests' result, I think your propose make sense.
There is no any method to change all controllers in only one time. change
with --entity-default only change the default value. it won't change the final
value if the value had been set.
So there is no need to highlight "only a single dynamic controller".if so.
it will hint the user "you can change all the controller instead of only one".
In fact. --entity-default is to change the default value.
1 alter command should contain entity-name or --entity-default in alter
command
root@ip-10-20-1-107:/usr/local/kafka/bin# ./kafka-configs.sh
--bootstrap-controller --bootstrap-controller 10.20.1.107:9889 --entity-type
brokers --command-config /etc/kafka/admin_config.properties --alter
--add-config max.connections=10086
**An entity-name or default entity must be specified with --alter of users,
clients, brokers or ips**
2 --entity-default is to update the default value:
DYNAMIC_DEFAULT_BROKER_CONFIG instead of the all controller.
root@ip-10-20-1-107:/usr/local/kafka/bin# ./kafka-configs.sh
--bootstrap-controller 10.20.1.107:9889 --entity-type brokers
**--entity-default** --command-config /etc/kafka/admin_config.properties
--alter --add-config **max.connections=10086**
Completed updating default config for brokers in the cluster.
root@ip-10-20-1-107:/usr/local/kafka/bin# ./kafka-configs.sh
--bootstrap-controller 10.20.1.107:9889 --entity-type brokers --entity-name
1001 --command-config /etc/kafka/admin_config.properties --describe --all
|grep -E 'max.connections|node'
max.connections=10086 sensitive=false
synonyms={**DYNAMIC_DEFAULT_BROKER_CONFIG:max.connections=10086**,
DEFAULT_CONFIG:max.connections=2147483647}
3 alert with --entity-name will override the default value. (note: after
changed. if alter with --entity-default. it won't change the final value. it
only change the default value)
root@ip-10-20-1-107:/usr/local/kafka/bin# ./kafka-configs.sh
--bootstrap-controller 10.20.1.107:9889 --entity-type brokers **--entity-name
1001** --command-config /etc/kafka/admin_config.properties --alter
--add-config max.connections=**10000**
Completed updating config for broker 1001.
root@ip-10-20-1-107:/usr/local/kafka/bin# ./kafka-configs.sh
--bootstrap-controller 10.20.1.107:9889 --entity-type brokers --entity-name
1001 --command-config /etc/kafka/admin_config.properties --describe --all
|grep -E 'max.connections|node'
max.connections=10000 sensitive=false
synonyms={**DYNAMIC_BROKER_CONFIG:max.connections=10000**,
**DYNAMIC_DEFAULT_BROKER_CONFIG:max.connections=10086**,
DEFAULT_CONFIG:max.connections=2147483647}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
