Pankraz76 commented on code in PR #21199:
URL: https://github.com/apache/kafka/pull/21199#discussion_r2637851025
##########
.github/workflows/build.yml:
##########
@@ -380,7 +400,7 @@ jobs:
exit 1
- name: Check Dependency Outcomes
run: |
- if [[ "${{ needs.validate.result }}" == "success" && "${{
needs.test.result }}" == "success" ]]; then
+ if [[ "${{ needs.validate.result }}" == "success" && ("${{
needs.configure.outputs.docChangeOnly }}" == "true" || "${{ needs.test.result
}}" == "success") ]]; then
Review Comment:
```suggestion
if [[ "${{ needs.validate.result }}" == "success" && (${{
needs.configure.outputs.docChangeOnly }} || "${{ needs.test.result }}" ==
"success") ]]; then
```
is it possible to to like above, using system check for the value?
##########
.github/workflows/build.yml:
##########
@@ -175,7 +195,7 @@ jobs:
test:
needs: [configure, validate, load-catalog]
- if: ${{ ! needs.configure.outputs.is-draft }}
Review Comment:
nice fix.
##########
.github/workflows/build.yml:
##########
@@ -38,6 +38,7 @@ jobs:
is-draft: ${{ steps.check-draft-pr.outputs.is-draft }}
test-catalog-days: ${{ steps.configure-outputs.outputs.days }}
sha: ${{ steps.configure-outputs.outputs.sha }}
+ docChangeOnly: ${{ steps.filter.outputs.docs == 'true' &&
steps.filter.outputs.code == 'false' }}
Review Comment:
```suggestion
docChangeOnly: ${{ steps.filter.outputs.docs &&
!steps.filter.outputs.code }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
