jolshan commented on code in PR #21176:
URL: https://github.com/apache/kafka/pull/21176#discussion_r2643878706
##########
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##########
@@ -185,6 +186,19 @@ public PartitionResponse(Errors error, long baseOffset,
long logAppendTime, long
this(error, baseOffset, logAppendTime, logStartOffset,
recordErrors, errorMessage, new ProduceResponseData.LeaderIdAndEpoch());
}
+ public PartitionResponse(Throwable exception, long baseOffset, long
logAppendTime, long logStartOffset, List<RecordError> recordErrors, String
errorMessage) {
Review Comment:
If it is for passing up the error back to the KafkaApis, it is also not
ideal as the handling for this exception starts leaking into the client code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
