chia7712 commented on code in PR #19489:
URL: https://github.com/apache/kafka/pull/19489#discussion_r2645182103
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -174,43 +174,6 @@ private void maybeRemoveAndDeallocateBatch(ProducerBatch
batch) {
this.accumulator.deallocate(batch);
}
- /**
- * Get the in-flight batches that has reached delivery timeout.
- */
- private List<ProducerBatch> getExpiredInflightBatches(long now) {
Review Comment:
I just left a comment on
https://github.com/apache/kafka/pull/21065#discussion_r2645158450
> Perhaps I can modify the bufferpool in this PR?
I prefer letting this PR implement the option 1, and we can use #21065 to
explore the another approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
