chickenchickenlove commented on code in PR #20969:
URL: https://github.com/apache/kafka/pull/20969#discussion_r2649048578
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##########
@@ -556,10 +556,41 @@ public synchronized void clean() {
try {
if (hasPersistentStores && stateDir.exists() &&
!stateDir.delete()) {
- log.warn(
- String.format("%s Failed to delete state store directory
of %s for it is not empty",
- logPrefix(), stateDir.getAbsolutePath())
- );
+ final File[] remainingFiles = stateDir.listFiles();
+ if (remainingFiles == null) {
+ log.warn("{} Failed to delete state store directory of {}
for it is not empty",
+ logPrefix(), stateDir.getAbsolutePath());
Review Comment:
Thanks for your comment.
Good point! I addressed the log message!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
