squah-confluent commented on PR #21269: URL: https://github.com/apache/kafka/pull/21269#issuecomment-3728885582
#21168's checks already exist as checkstyle's [AvoidDoubleBraceInitialization](https://checkstyle.sourceforge.io/checks/coding/avoiddoublebraceinitialization.html) and spotbugs' [UPM_UNCALLED_PRIVATE_METHOD](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#upm-private-method-is-never-called-upm-uncalled-private-method). It looks like your goal here is to introduce openrewrite as a whole rather than add any particular check. The project already runs checkstyle for linting and spotbugs for static analysis. I do not think it makes sense to add a _second_ linting and static analysis pass because of the overlap in functionality. If the proposal is to _replace_ checkstyle and spotbugs with openrewrite, we should discuss that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
