clolov commented on PR #20866: URL: https://github.com/apache/kafka/pull/20866#issuecomment-3729179462
Thanks for the change and apologies for the delay! It may be because my expertise in Gradle is not my strong suit, but I would encourage you to give a brief overview of why all the changes in the PR are required! The real problem is that if we just bump Gradle Shadow from 8 to 9 we run into ``` * What went wrong: Execution failed for task ':jmh-benchmarks:shadowJar'. > Cannot expand ZIP '/Users/REDACTED/Documents/kafka/core/build/classes/java/test' as it does not exist. ``` which appears to be because :core only has build/classes/scala while all other dependencies have build/classes/java and Gradle Shadow 9 appears to be more strict in requiring that directory to exist. I am a bit on the fence for this change. On one hand, I don't like depending on .sourceSets.test.output in some places in the build.gradle file and on configurations/artifacts in others. On the other hand, I also don't like generating an empty folder (i.e. build/classes/java) just to satisfy a stricter expectation. What are the opinions of others in the community? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
