joshua2519 commented on code in PR #21261:
URL: https://github.com/apache/kafka/pull/21261#discussion_r2682329821
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -207,4 +208,30 @@ private static String parseListenerName(String
connectionString) {
}
return connectionString.substring(0,
firstColon).toUpperCase(Locale.ROOT);
}
+
+ /**
+ * Registers a component for dynamic reconfiguration notifications.
+ * <p>
+ * This method exists to support migration from kafka.server.KafkaConfig
(Scala/core) to AbstractKafkaConfig (Java/server).
+ * When migrating code, replace KafkaConfig references with
AbstractKafkaConfig. The default implementation is a no-op;
+ * KafkaConfig overrides this to manage the reconfigurable registry.
+ *
+ * @param reconfigurable the component to register for configuration
updates
+ */
+ public void addReconfigurable(Reconfigurable reconfigurable) {
Review Comment:
Agreed and changed. Since all current implementations (KafkaConfig) already
provide concrete implementations, making them abstract clarifies the contract
and ensures future subclasses don't accidentally rely on no-op behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
