lucasbru commented on code in PR #21272: URL: https://github.com/apache/kafka/pull/21272#discussion_r2686599464
########## core/src/main/java/kafka/server/KRaftTopicCreator.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package kafka.server; + +import org.apache.kafka.clients.ClientResponse; +import org.apache.kafka.common.errors.TimeoutException; +import org.apache.kafka.common.protocol.ApiKeys; +import org.apache.kafka.common.protocol.Errors; +import org.apache.kafka.common.requests.AbstractRequest; +import org.apache.kafka.common.requests.AbstractResponse; +import org.apache.kafka.common.requests.CreateTopicsRequest; +import org.apache.kafka.common.requests.CreateTopicsResponse; +import org.apache.kafka.common.requests.EnvelopeResponse; +import org.apache.kafka.common.requests.RequestContext; +import org.apache.kafka.common.requests.RequestHeader; +import org.apache.kafka.server.common.ControllerRequestCompletionHandler; +import org.apache.kafka.server.common.NodeToControllerChannelManager; + +import java.io.IOException; +import java.util.concurrent.CompletableFuture; + +/** + * KRaft implementation of TopicCreator that forwards CreateTopics requests to the controller. + * When creating topics with a principal, requests are wrapped in an envelope to preserve the + * original request context for authorization. + */ +public class KRaftTopicCreator implements TopicCreator { + + private final NodeToControllerChannelManager channelManager; + + public KRaftTopicCreator(NodeToControllerChannelManager channelManager) { + this.channelManager = channelManager; + } + + @Override + public CompletableFuture<CreateTopicsResponse> createTopicWithPrincipal( + RequestContext requestContext, + CreateTopicsRequest.Builder createTopicsRequest + ) { + CompletableFuture<CreateTopicsResponse> responseFuture = new CompletableFuture<>(); + + short requestVersion; + if (channelManager.controllerApiVersions().isEmpty()) { + requestVersion = ApiKeys.CREATE_TOPICS.latestVersion(); + } else { + requestVersion = channelManager.controllerApiVersions().get() + .latestUsableVersion(ApiKeys.CREATE_TOPICS); + } + + RequestHeader requestHeader = new RequestHeader( + ApiKeys.CREATE_TOPICS, + requestVersion, + requestContext.clientId(), + requestContext.correlationId() + ); + + AbstractRequest.Builder<? extends AbstractRequest> envelopeRequest = ForwardingManager$.MODULE$.buildEnvelopeRequest( Review Comment: Yes, let's do that in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
