0xffff-zhiyan commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2692223999
##########
metadata/src/main/java/org/apache/kafka/image/ConfigurationDelta.java:
##########
@@ -58,17 +64,19 @@ public void deleteAll() {
public ConfigurationImage apply() {
Map<String, String> newData = new HashMap<>(image.data().size());
for (Entry<String, String> entry : image.data().entrySet()) {
- Optional<String> change = changes.get(entry.getKey());
+ String configName = entry.getKey();
Review Comment:
Yes! we don't add validation in `apply`. It's just some irrelevant changes I
forgot to remove. will remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
