jsancio commented on code in PR #21221:
URL: https://github.com/apache/kafka/pull/21221#discussion_r2705696478


##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1194,6 +1201,14 @@ ControllerResult<AlterPartitionResponseData> 
alterPartition(
         return ControllerResult.of(records, response);
     }
 
+    private static String logPartitionChangeInfo(PartitionRegistration 
oldRegistration, PartitionRegistration newRegistration) {
+        return String.format("isr: %s -> %s, replicaSet: %s -> %s, 
partitionEpoch: %d -> %d, leaderEpoch: %d -> %d",

Review Comment:
   Okay but you can use `%s` for all of these formats. `%d` is different from 
`%s` only if you use `%d`'s special formatting rules like `%09d`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to