mumrah commented on code in PR #21313:
URL: https://github.com/apache/kafka/pull/21313#discussion_r2708799474
##########
clients/src/main/java/org/apache/kafka/common/Uuid.java:
##########
@@ -70,12 +70,12 @@ private static Uuid unsafeRandomUuid() {
/**
* Static factory to retrieve a type 4 (pseudo randomly generated) UUID.
- *
- * This will not generate a UUID equal to 0, 1, or one whose string
representation starts with a dash ("-")
+ * <p>
+ * This will not generate a UUID equal to 0, 1, or one whose string
representation contains a dash ("-").
*/
public static Uuid randomUuid() {
Uuid uuid = unsafeRandomUuid();
- while (RESERVED.contains(uuid) || uuid.toString().startsWith("-")) {
+ while (RESERVED.contains(uuid) || uuid.toString().contains("-")) {
Review Comment:
Thanks for doing the math :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
