dajac commented on code in PR #21334:
URL: https://github.com/apache/kafka/pull/21334#discussion_r2712601768


##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1792,8 +1791,7 @@ class KafkaApis(val requestChannel: RequestChannel,
               marker.producerEpoch,
               marker.coordinatorEpoch,
               marker.transactionResult,
-              markerTransactionVersion,
-              Duration.ofMillis(config.requestTimeoutMs.toLong)

Review Comment:
   There is one change worth pointing out. This is the only case were we did 
not use the default timeout (the offset timeout). However, I don't really a 
reason to not use it in order to be consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to