kamalcph commented on PR #20428: URL: https://github.com/apache/kafka/pull/20428#issuecomment-3811415961
@abhijeetk88 Could you please split this patch into two? The below case seem to bring additional complexity to the code and can be taken in the next patch if required: ``` If this code change is to handle the case when leader-log-start-offset == leader-local-log-start-offset == 0 and earliestUploadOffset > 0 (yet to be approved), then we may have to discuss it before proceeding with the patch. It is one of the edge-case but not sure how useful it would be in practice. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
