jiafu1115 commented on PR #21361: URL: https://github.com/apache/kafka/pull/21361#issuecomment-3814834834
@kamalcph After a deeper dive, I understand it now. Thanks a lot for pointing this out. The maxTimestamp in log segments may not increase monotonically due to the use of ProduceTime, or because of NTP / system clock adjustments. Based on this, I think I should update the code by changing continue to break with the next segment be evaluated. This way, the behavior will keep consistent with the time-based retention logic. I can take some time to work on this change. Once I feel it’s ready, I’d really appreciate your help to review it again. For now, I’ll focus on the KIP first. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
