mannoopj commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r2755390334
##########
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##########
@@ -1174,35 +1174,6 @@ class KRaftClusterTest {
}
}
- @Test
- def testStartupWithNonDefaultKControllerDynamicConfiguration(): Unit = {
Review Comment:
Originally this test used KafkaClusterTestKit which passed the full
BootstrapMetadata (with injected ConfigRecord) into
ControllerServer/QuorumController, and on an empty metadata log the controller
appends and replays those bootstrap records, so the config takes effect at
startup. With the changes in this PR KafkaClusterTestKit.format() drives
Formatter, and Formatter only generates bootstrap records from release version
+ feature levels (+ SCRAM) and does not accept arbitrary ConfigRecords, so
injecting a ConfigRecord through BootstrapMetadata.fromRecords() doesn't work
and doesn't get picked up. I moved it to DynamicBrokerReconfigurationTest as it
seemed like the closest fit of where i could move this test without running
into this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
