lianetm commented on code in PR #21388:
URL: https://github.com/apache/kafka/pull/21388#discussion_r2758679907
##########
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandOptions.java:
##########
@@ -86,6 +87,15 @@ public ReassignPartitionsCommandOptions(String[] args) {
.describedAs("brokerlist")
.ofType(String.class);
+ brokerListWithoutThrottleOpt =
parser.accepts("broker-list-without-throttle", "Optional. Comma-separated
broker ID list (e.g. 1,2) that " +
+ "should be excluded from broker-level throttle config
updates during partition reassignment execution. " +
+ "When --execute and --throttle are used, it normally
applies throttle configs on all brokers involved in the reassignment. " +
+ "If any of those brokers are known to be down or
unreachable, adding them to --broker-list-without-throttle makes it " +
+ "skip the throttle-setting step for those brokers,
avoiding retries/timeouts, while still throttling the remaining reachable
brokers.")
+ .withRequiredArg()
+ .describedAs("broker list without throttle")
+ .ofType(String.class);
Review Comment:
this is adding a new param to a command line tool (public API), so it would
need a KIP to discuss and approve with the community. You can find info here
and take it from there
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-Process
Thanks for looking into this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
