squah-confluent commented on code in PR #21396:
URL: https://github.com/apache/kafka/pull/21396#discussion_r2760469572
##########
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeTest.java:
##########
@@ -5695,6 +5695,86 @@ public void
testLingerTimeComparisonInMaybeFlushCurrentBatch() throws Exception
assertEquals(0, schedulerTimer.size());
}
+ @Test
+ public void
testScheduleUnloadingWithPendingBatchWhenPartitionWriterConfigThrows() {
+ MockTimer timer = new MockTimer();
+ MockPartitionWriter writer = mock(MockPartitionWriter.class);
+ MockCoordinatorShardBuilderSupplier supplier =
mock(MockCoordinatorShardBuilderSupplier.class);
+ MockCoordinatorShardBuilder builder =
mock(MockCoordinatorShardBuilder.class);
+ MockCoordinatorShard coordinator = mock(MockCoordinatorShard.class);
+
+ CoordinatorRuntime<MockCoordinatorShard, String> runtime =
+ new CoordinatorRuntime.Builder<MockCoordinatorShard, String>()
+ .withTime(timer.time())
+ .withTimer(timer)
+ .withDefaultWriteTimeOut(Duration.ofMillis(20))
Review Comment:
nit: Could we use `DEFAULT_WRITE_TIMEOUT` here unless there's a reason to
use a different timeout?
```suggestion
.withDefaultWriteTimeOut(DEFAULT_WRITE_TIMEOUT)
```
##########
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeTest.java:
##########
@@ -5695,6 +5695,86 @@ public void
testLingerTimeComparisonInMaybeFlushCurrentBatch() throws Exception
assertEquals(0, schedulerTimer.size());
}
+ @Test
+ public void
testScheduleUnloadingWithPendingBatchWhenPartitionWriterConfigThrows() {
Review Comment:
Could we move this together with the rest of the `testScheduleUnloading*`
tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
