lucliu1108 commented on PR #20969: URL: https://github.com/apache/kafka/pull/20969#issuecomment-3843261520
Thanks all for the input! @chickenchickenlove @mjsax @bbejeck @lucasbru > Avoid the warning sounds good, since things are working as intended, but I would still log at INFO level that we are keeping the directory due to the process ID file. I agree, this situation would be better to log at INFO level rather than DEBUG level. I suppose this method won't be called quite often to spam the logs, so INFO level could serve the purpose well. Could someone confirm how often this method would be called in practice? If i understand correctly, right now the next step for @chickenchickenlove would be: 1. A small KIP for the logging change 2. Following 1, do Java API doc revision that describes the accurate `cleanUp()` contact for metadata. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
