nicktelford commented on code in PR #20955:
URL: https://github.com/apache/kafka/pull/20955#discussion_r2764849405


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractReadWriteDecorator.java:
##########
@@ -48,6 +50,11 @@ public void init(final StateStoreContext stateStoreContext,
         throw new UnsupportedOperationException(ERROR_MESSAGE);
     }
 
+    @Override
+    public void commit(final Map<TopicPartition, Long> changelogOffsets) {

Review Comment:
   Hmm, not sure how I missed this. I must have not run the full test suite 
properly!
   
   The correct solution here is to remove the call to `store.commit(Map.of())` 
from the `Processor` used in the integration test, as `commit` should never be 
called from a user's `Processor`.
   
   There looks to be a similar bug in `EosIntegrationTest` too. I'll fix them 
both and re-run the full integration test suite.
   
   Thanks for spotting this!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to