frankvicky commented on code in PR #21409:
URL: https://github.com/apache/kafka/pull/21409#discussion_r2775416688
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/HeadersSerializerTest.java:
##########
@@ -131,29 +129,4 @@ public void shouldSerializeHeadersWithEmptyValue() {
assertEquals("key1", header.key());
assertArrayEquals(new byte[0], header.value());
}
-
- @Test
- public void shouldSerializeHeadersWithSpecialCharacters() {
Review Comment:
TL;DR It should be useless if we only test `_`, `-`, `.`, they are common in
daily use. If we want to keep this case, we should test some edge case(e.g.
emoji).
ref: https://github.com/apache/kafka/pull/21401#discussion_r2773432276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
