fvaleri commented on code in PR #21443:
URL: https://github.com/apache/kafka/pull/21443#discussion_r2787330530
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java:
##########
@@ -35,12 +35,14 @@ public class DefaultConfigPropertyFilter implements
ConfigPropertyFilter {
private static final String CONFIG_PROPERTIES_EXCLUDE_DOC = "List of topic
configuration properties and/or regexes "
+ "that should
not be replicated.";
- public static final String CONFIG_PROPERTIES_EXCLUDE_DEFAULT =
"follower\\.replication\\.throttled\\.replicas, "
- +
"leader\\.replication\\.throttled\\.replicas, "
- +
"message\\.timestamp\\.difference\\.max\\.ms, "
- +
"message\\.timestamp\\.type, "
- +
"unclean\\.leader\\.election\\.enable, "
- +
"min\\.insync\\.replicas";
+ public static final String CONFIG_PROPERTIES_EXCLUDE_DEFAULT =
"follower.replication.throttled.replicas, "
+ +
"leader.replication.throttled.replicas, "
+ +
"message.timestamp.difference.max.ms, "
+ +
"log.message.timestamp.before.max.ms, "
+ +
"log.message.timestamp.after.max.ms, "
+ +
"message.timestamp.type, "
+ +
"unclean.leader.election.enable, "
+ +
"min.insync.replicas";
Review Comment:
Removing double backslash before full stops is fine in practice. An
unescaped full stop would only cause a false match if there were a config
property name identical except with a different character where a dot is (e.g.
`minXinsync.replicas`), which doesn't exist in Kafka's config space. The
readability improvement outweighs the theoretical imprecision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
