mjsax commented on code in PR #20726:
URL: https://github.com/apache/kafka/pull/20726#discussion_r2794976082
##########
checkstyle/suppressions.xml:
##########
@@ -371,4 +371,8 @@
<!-- Add the new suppression rule for JaasTestUtils.java -->
<suppress checks="ImportControl" files="(JaasTestUtils).java" />
+
+ <suppress checks="FinalLocalVariable" files="."/>
+ <suppress checks="FinalParameters" files="."/>
Review Comment:
I didn't pay attention to this PR, but upgrading a dependency should not
change any checkstyle rules... We should not have disabled this; inside KS
module, we have this rule for a long time, and want to keep it (personally, I
would think it would actually be good to even expand its scope to the entire
code base, but that's a different discussion, and I don't want to touch it at
this point)
Fixing via https://github.com/apache/kafka/pull/21456
\cc @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
