mjsax commented on code in PR #21433:
URL: https://github.com/apache/kafka/pull/21433#discussion_r2795101117
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1879,6 +1879,9 @@ private void completeShutdown(final boolean cleanRun) {
try {
final GroupMembershipOperation membershipOperation =
leaveGroupRequested.get() ==
org.apache.kafka.streams.CloseOptions.GroupMembershipOperation.LEAVE_GROUP ?
LEAVE_GROUP : REMAIN_IN_GROUP;
+ if (membershipOperation == REMAIN_IN_GROUP &&
streamsRebalanceData.isPresent()) {
Review Comment:
Thanks. If we have this pattern already, maybe not worth to to a larger
change... I understand the redundancy argument; so overall not sure what the
best thing would be. Maybe it doesn't matter too much overall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
