chia7712 commented on code in PR #21456:
URL: https://github.com/apache/kafka/pull/21456#discussion_r2796016154
##########
checkstyle/suppressions.xml:
##########
@@ -222,10 +222,13 @@
<suppress checks="(NPathComplexity|CyclomaticComplexity)"
files="(KStreamSlidingWindowAggregate|RackAwareTaskAssignor).java"/>
- <!-- suppress FinalLocalVariable outside of the streams package. -->
+ <!-- suppress FinalLocalVariable and FinalParameters outside of the
streams package. -->
<suppress checks="FinalLocalVariable"
Review Comment:
Thanks for the fix. I agree that keeping the rule for the streams module is
the better approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
