chia7712 commented on code in PR #21450:
URL: https://github.com/apache/kafka/pull/21450#discussion_r2797007458
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -199,7 +199,7 @@ public static Set<String> configNames() {
*/
public static void validateNames(Properties props) {
Review Comment:
Consider refactoring the call path to use `Map` instead. I didn't see the
specific benefit of using `Properties` here
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1370,16 +1370,14 @@ ConsumerGroup convertToConsumerGroup(ClassicGroup
classicGroup, List<Coordinator
metadataImage
);
} catch (SchemaException e) {
- log.warn("Cannot upgrade classic group " + classicGroup.groupId() +
- " to consumer group because the embedded consumer protocol is
malformed: "
- + e.getMessage() + ".", e);
+ log.warn("Cannot upgrade classic group {} to consumer group
because the embedded consumer protocol is malformed: {}.",
+ classicGroup.groupId(), e.getMessage(), e);
Review Comment:
ditto
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1289,8 +1289,8 @@ private void convertToClassicGroup(
metadataImage
);
} catch (SchemaException e) {
- log.warn("Cannot downgrade the consumer group " +
consumerGroup.groupId() + ": fail to parse " +
- "the Consumer Protocol " + ConsumerProtocol.PROTOCOL_TYPE +
".", e);
+ log.warn("Cannot downgrade the consumer group {}: fail to parse
the Consumer Protocol {}.",
+ consumerGroup.groupId(), ConsumerProtocol.PROTOCOL_TYPE,
e);
Review Comment:
Please remove the unnecessary indent
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -199,7 +199,7 @@ public static Set<String> configNames() {
*/
public static void validateNames(Properties props) {
Review Comment:
we can address that in a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
