DL1231 commented on code in PR #21467:
URL: https://github.com/apache/kafka/pull/21467#discussion_r2802643908
##########
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##########
@@ -275,6 +276,20 @@ public static int
recordLockDurationMsOrDefault(GroupConfigManager groupConfigMa
return defaultValue;
}
+ /**
+ * The method is used to check if renew acknowledge is enabled for the
group. If the group config
+ * is present, then the value from the group config is used. Otherwise,
the default value is used.
+ *
+ * @param groupConfigManager The group config manager.
+ * @param groupId The group id for which the renew acknowledge enable is
to be checked.
+ * @return true if renew acknowledge is enabled for the group, false
otherwise.
+ */
+ public static boolean isRenewAcknowledgeEnabled(GroupConfigManager
groupConfigManager, String groupId) {
Review Comment:
Moving this to `GroupMetadataManager` would require introducing
`GroupMetadataManager` as a new dependency of `SharePartition`, which seems
like unnecessary coupling. The similar config-accessor methods in
`GroupMetadataManager` (e.g., `consumerGroupSessionTimeoutMs`) serve the
coordinator's own internal logic, whereas this helper serves the share
partition layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
