mimaison commented on code in PR #21471:
URL: https://github.com/apache/kafka/pull/21471#discussion_r2803158323
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##########
@@ -1114,6 +1114,9 @@ private void maybeThrowInvalidGroupIdException() {
throw new InvalidGroupIdException(
"You must provide a valid " +
ConsumerConfig.GROUP_ID_CONFIG + " in the consumer configuration.");
}
+ if (groupId.contains(":")) {
+ throw new InvalidGroupIdException("Group ID must not contain ':'
for share consumers.");
+ }
Review Comment:
While this is the easy fix, I'm not sure it's the best option. Changing the
allowed characters in a group name would typically require a KIP. Can't we
adjust the split logic to start from the end? The topic name cannot contain a
colon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
