clolov commented on code in PR #21475: URL: https://github.com/apache/kafka/pull/21475#discussion_r2805281268
########## server/src/main/java/org/apache/kafka/server/HostedPartition.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.server; + +/** + * Sealed interface to represent the state of hosted partitions. We create a concrete (active) Partition + * instance when the broker receives a LeaderAndIsr request from the controller or a metadata + * log record from the Quorum controller indicating that the broker should be either a leader + * or follower of a partition. + */ +public sealed interface HostedPartition<T> permits None, Online, Offline { } Review Comment: Okay, hopefully the latest version address this 😊! I was trying to put the records on the same level as the interface, but they should have been put nested inside the interface! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
