[ 
https://issues.apache.org/jira/browse/KAFKA-20131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk True updated KAFKA-20131:
------------------------------
    Description: 
When {{ClassicKafkaConsumer.currentLag()}} is called, 
{{SubscriptionState.requestPartitionEndOffset()}} is called, which sets a 
per-partition flag named {{endOffsetRequested}}. This flag is later cleared by 
{{SubscriptionState.updateLastStableOffset()}}/{{SubscriptionState.updateHighWatermark()}}
 when a successful {{LIST_OFFSETS}} call is received. However, if the partition 
has an error code in the response, or the {{LIST_OFFSETS}} call itself fails, 
neither update method is called, and {{endOffsetRequested}} remains set. The 
problem is, on _any subsequent_ call to {{ClassicKafkaConsumer.currentLag()}}, 
the logic will see that {{endOffsetRequested}} is already set, and the offset 
request will be silently ignored.

The fix is to ensure that {{endOffsetRequested}} is cleared out even on failure 
cases.

  was:
When {{Consumer.currentLag()}} is called, 
{{SubscriptionState.requestPartitionEndOffset()}} is called, which sets a 
per-partition flag named {{endOffsetRequested}}. This flag is later cleared by 
{{SubscriptionState.updateLastStableOffset()}}/{{SubscriptionState.updateHighWatermark()}}
 when a successful {{LIST_OFFSETS}} call is received. However, if the partition 
has an error code in the response, or the {{LIST_OFFSETS}} call itself fails, 
neither update method is called, and {{endOffsetRequested}} remains set. The 
problem is, on _any subsequent_ call to {{Consumer.currentLag()}}, the logic 
will see that {{endOffsetRequested}} is already set, and the offset request 
will be silently ignored.

The fix is to ensure that {{endOffsetRequested}} is cleared out even on failure 
cases.


> ClassicKafkaConsumer does not clear endOffsetRequested flag on failed 
> LIST_OFFSETS calls
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-20131
>                 URL: https://issues.apache.org/jira/browse/KAFKA-20131
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients, consumer
>    Affects Versions: 3.0.0, 3.9.1, 4.2.0
>            Reporter: Kirk True
>            Assignee: Kirk True
>            Priority: Critical
>             Fix For: 3.9.2, 4.3.0, 4.0.2, 4.1.2, 4.2.1
>
>
> When {{ClassicKafkaConsumer.currentLag()}} is called, 
> {{SubscriptionState.requestPartitionEndOffset()}} is called, which sets a 
> per-partition flag named {{endOffsetRequested}}. This flag is later cleared 
> by 
> {{SubscriptionState.updateLastStableOffset()}}/{{SubscriptionState.updateHighWatermark()}}
>  when a successful {{LIST_OFFSETS}} call is received. However, if the 
> partition has an error code in the response, or the {{LIST_OFFSETS}} call 
> itself fails, neither update method is called, and {{endOffsetRequested}} 
> remains set. The problem is, on _any subsequent_ call to 
> {{ClassicKafkaConsumer.currentLag()}}, the logic will see that 
> {{endOffsetRequested}} is already set, and the offset request will be 
> silently ignored.
> The fix is to ensure that {{endOffsetRequested}} is cleared out even on 
> failure cases.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to