lianetm commented on code in PR #21457:
URL: https://github.com/apache/kafka/pull/21457#discussion_r2806148758
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcher.java:
##########
@@ -153,11 +169,17 @@ public void onSuccess(ListOffsetResult value) {
remainingToSearch.keySet().retainAll(value.partitionsToRetry);
offsetFetcherUtils.updateSubscriptionState(value.fetchedOffsets,
isolationLevel);
+
+ if (isZeroTimestamp && shouldClearPartitionEndOffsets)
Review Comment:
shouldn't we clear the flag `if (isZeroTimestamp)`?
I see the `shouldClearPartitionEndOffsets` is passed true only from
`currentLag`, but what about a call to
consumer.`endOffsets`/`beginningOffsets`/`offsetsForTimes` when called with
`Duration.ZERO`? how would the flag get cleared?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
