mjsax commented on code in PR #21451:
URL: https://github.com/apache/kafka/pull/21451#discussion_r2807009527
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##########
@@ -420,11 +421,11 @@ public void close() {
}
protected V outerValue(final byte[] value) {
- return value != null ? serdes.valueFrom(value) : null;
+ return value != null ? serdes.valueFrom(value, new RecordHeaders()) :
null;
}
protected Bytes keyBytes(final K key) {
Review Comment:
Looking into the POC PR, we actually added `Headers` parameter here, and I
think it would be the right thing to do, and just pass in `new RecrodHeaders()`
when used inside `MeteredKeyValueStore` but pass in the extracted `Headers`
object from the value in the `MeteredTimestampedKeyValueWithHeadersStore` case?
This implies we need to overload `put()` in
`MeteredTimestampedKeyValueWithHeadersStore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
