mjsax commented on code in PR #21454:
URL: https://github.com/apache/kafka/pull/21454#discussion_r2807032803
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializer.java:
##########
@@ -164,4 +164,17 @@ static Headers headers(final byte[]
rawValueTimestampHeaders) {
final byte[] rawHeaders = readBytes(buffer, headersSize);
return HEADERS_DESERIALIZER.deserialize("", rawHeaders);
}
+ /**
+ * Extract raw value from serialized ValueTimestampHeaders.
+ */
+ static byte[] rawValue(final byte[] rawValueTimestampHeaders) {
Review Comment:
Yes, I am not questioning that we add `rawValue` in this PR, I am asking why
did we add `value(...)` in a previous PR, and when would we use it?
But it's somewhat unrelated to this PR, and it's only internal code here. So
we could remove `value(...)` if unused also at some point in the future. Was
just wondering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
