zooo-code commented on code in PR #21429:
URL: https://github.com/apache/kafka/pull/21429#discussion_r2820076789
##########
clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgeType.java:
##########
@@ -46,7 +47,13 @@ public String toString() {
return super.toString().toLowerCase(Locale.ROOT);
}
-
+ /**
+ * Returns the AcknowledgeType for the given identifier.
+ *
+ * @param id the identifier for the acknowledge type
+ * @return the corresponding AcknowledgeType
+ * @throws IllegalArgumentException if the id is not recognized
Review Comment:
Done!
Also applied the same capitalization fix across all other files in the patch.
Thanks for the detailed review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
