aliehsaeedii commented on code in PR #21455:
URL: https://github.com/apache/kafka/pull/21455#discussion_r2834978978
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBKeyValueBytesStoreSupplier.java:
##########
@@ -38,9 +41,13 @@ public String name() {
@Override
public KeyValueStore<Bytes, byte[]> get() {
- return returnTimestampedStore ?
- new RocksDBTimestampedStore(name, metricsScope()) :
- new RocksDBStore(name, metricsScope());
+ if (returnHeadersStore) {
Review Comment:
I'm OK with checking both flags but if headers store is going to be built, I
prefer `returnTimestampedStore == false and returnHeadersStore == true` rather
`returnTimestampedStore == true and returnHeadersStore == true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
