UladzislauBlok commented on code in PR #21536:
URL: https://github.com/apache/kafka/pull/21536#discussion_r2836378598
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MergedSortedCacheWindowStoreKeyValueIterator.java:
##########
@@ -76,7 +78,7 @@ KeyValue<Windowed<Bytes>, byte[]> deserializeStorePair(final
KeyValue<Windowed<B
@Override
Windowed<Bytes> deserializeCacheKey(final Bytes cacheKey) {
final byte[] binaryKey = cacheFunction.key(cacheKey).get();
- return storeKeyToWindowKey.toWindowKey(binaryKey, windowSize,
serdes.keyDeserializer(), serdes.topic());
+ return storeKeyToWindowKey.toWindowKey(binaryKey, windowSize,
serdes.keyDeserializer(), new RecordHeaders(), serdes.topic());
Review Comment:
AFAIU we don't need headers here, because expected return type is
Windowed<**Bytes**>, but of you see any cases when headers will be needed for
bytes -> bytes deserialization, I will change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
