lianetm commented on PR #21464:
URL: https://github.com/apache/kafka/pull/21464#issuecomment-3951457566

   > I wonder why it was dropped starting from v1. Was it missed during a 
refactoring (e.g. when batching was introduced)?
   
   From what I see in the history it was indeed dropped when group batching was 
introduced with the implementation of KIP-709, mainly because with that we 
split the handling to read from zk vs read offsets from the internal topic 
(that made the difference)
   
   With the split handling introduced in that PR, v0 reads offsets from zk and 
throws UNKNOWN_TOPIC_OR_PARTITION if not found. And v1+ reads offsets from the 
internal topic, and the GC returns no error + offsets -1 if not found. This 
func introduced for KIP-709 
https://github.com/apache/kafka/pull/10962/changes#diff-cc056b4960ededba37a438b1454f0f3c5ff5e8ad5e6d2ec9a08e813ca056ffebR1316
 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to