mimaison commented on code in PR #21523:
URL: https://github.com/apache/kafka/pull/21523#discussion_r2848354240
##########
server/src/test/java/org/apache/kafka/server/CordonedLogDirsIntegrationTest.java:
##########
@@ -223,30 +228,119 @@ public void testReassignWithCordonedLogDirs() throws
Exception {
assertInstanceOf(InvalidReplicaAssignmentException.class,
ee.getCause());
// After uncordoning the log dir, we can move the replica on it
- setCordonedLogDirs(admin, List.of());
+ setCordonedLogDirs(admin, List.of(), BROKER_0);
admin.alterReplicaLogDirs(Map.of(replica,
otherLogDir)).all().get();
}
}
- private Map<ConfigResource, Collection<AlterConfigOp>>
cordonedDirsConfig(String value) {
+ @ClusterTest(
+ brokers = 2,
+ controllers = 1
+ )
+ public void testDecommissionBroker() throws ExecutionException,
InterruptedException {
Review Comment:
Yes feel free to pick it up. Thanks! You have a template with
`testDecommissionBroker()`, the test for log directories should be fairly
similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
