chia7712 commented on code in PR #21601:
URL: https://github.com/apache/kafka/pull/21601#discussion_r2876719551
##########
build.gradle:
##########
@@ -2046,6 +2046,7 @@ project(':clients') {
include "**/org/apache/kafka/common/security/scram/*"
include "**/org/apache/kafka/common/security/token/delegation/*"
include "**/org/apache/kafka/common/serialization/*"
+ include "**/org/apache/kafka/common/utils/Bytes.java"
Review Comment:
Make sense. Let's stick with `include
"**/org/apache/kafka/common/utils/Bytes.java` and leave `Time`, `Timer`, and
`Bytes` in their original package. That could minimize the surprise. Also, it
would be helpful to add comments to `package-info.java` mentioning the KIP that
will discuss the exposition of the `Time` and `Timer` classes. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
