Nikita-Shupletsov commented on code in PR #21117:
URL: https://github.com/apache/kafka/pull/21117#discussion_r2879499050
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -956,7 +955,10 @@ private void handleTimeoutFailure(long now, Throwable
cause) {
log.debug("{} timed out at {} after {} attempt(s)", this, now,
tries,
new Exception(prettyPrintException(cause)));
}
- if (cause instanceof TimeoutException) {
+ // Don't mask OutOfMemoryError as TimeoutException - propagate it
directly
+ if (cause instanceof OutOfMemoryError) {
Review Comment:
yeah, I understand that, sorry for not being crisp. My question was more
like: as we found that problem with OutOfMemoryError, should we treat all
errors the same way? I am not sure if StackOverFlowError for example is a
retriable error in that context, or NotSuchMethodError.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
