jsancio commented on code in PR #21619:
URL: https://github.com/apache/kafka/pull/21619#discussion_r2879974564
##########
core/src/main/scala/kafka/server/ControllerRegistrationManager.scala:
##########
@@ -267,6 +267,7 @@ class ControllerRegistrationManager(
}
override def onTimeout(): Unit = {
+ pendingRpc = false
Review Comment:
> registration idempotent
How about the response sent to the broker? The response sent to the broker
is important since that is what stops the broker from rescheduling registration
requests.
> I'm a bit confused on this one, maybe I am misunderstanding. If the local
node has not sent a request to the active controller, how can we get a reponse?
I was trying to affirm that if onTimeout is called, it means that the
request was not sent and will not be sent. This is important since it means
that in this case the broker doesn't need to worry about the controller
handling multiple requests and the broker receiving multiple registration
responses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
