chia7712 commented on code in PR #21550:
URL: https://github.com/apache/kafka/pull/21550#discussion_r2884142313
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -584,6 +584,14 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
// warn if create.topic.policy.class.name or
alter.config.policy.class.name is defined in the broker role
warnIfConfigDefinedInWrongRole(ProcessRole.ControllerRole,
ServerLogConfigs.CREATE_TOPIC_POLICY_CLASS_NAME_CONFIG)
warnIfConfigDefinedInWrongRole(ProcessRole.ControllerRole,
ServerLogConfigs.ALTER_CONFIG_POLICY_CLASS_NAME_CONFIG)
+ if (originals.containsKey(ServerLogConfigs.NUM_PARTITIONS_CONFIG)) {
Review Comment:
Could you refactor `warnIfConfigDefinedInWrongRole` to ensure consistent
warning messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
