mjsax commented on code in PR #21636:
URL: https://github.com/apache/kafka/pull/21636#discussion_r2887399815
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/KeyValueSegmentsTest.java:
##########
@@ -305,7 +305,7 @@ public void
shouldUpdateSegmentFileNameFromOldDateFormatToNewFormat() throws Exc
for (int segmentId = 0; segmentId < NUM_SEGMENTS; ++segmentId) {
final File oldSegment = new File(storeDirectoryPath +
File.separator + storeName + "-" + formatter.format(new Date(segmentId *
segmentInterval)));
//noinspection ResultOfMethodCallIgnored
- Files.createFile(oldSegment.toPath());
+ Files.createDirectory(oldSegment.toPath());
Review Comment:
Segments are directories -- if we create it here as a file, we later fail
trying to create it as directory (create dir passed if dir already exists)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
