mjsax commented on code in PR #21599: URL: https://github.com/apache/kafka/pull/21599#discussion_r2887538277
########## streams/src/test/java/org/apache/kafka/streams/processor/internals/WindowStoreMaterializerTest.java: ########## @@ -0,0 +1,311 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.streams.processor.internals; + +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.kstream.EmitStrategy; +import org.apache.kafka.streams.kstream.Materialized; +import org.apache.kafka.streams.kstream.TimeWindows; +import org.apache.kafka.streams.kstream.Windows; +import org.apache.kafka.streams.kstream.internals.InternalNameProvider; +import org.apache.kafka.streams.kstream.internals.MaterializedInternal; +import org.apache.kafka.streams.kstream.internals.WindowStoreMaterializer; +import org.apache.kafka.streams.processor.StateStore; +import org.apache.kafka.streams.state.BuiltInDslStoreSuppliers; +import org.apache.kafka.streams.state.DslStoreSuppliers; +import org.apache.kafka.streams.state.TimestampedWindowStore; +import org.apache.kafka.streams.state.TimestampedWindowStoreWithHeaders; +import org.apache.kafka.streams.state.WindowBytesStoreSupplier; +import org.apache.kafka.streams.state.WindowStore; +import org.apache.kafka.streams.state.internals.CachingWindowStore; +import org.apache.kafka.streams.state.internals.ChangeLoggingTimestampedWindowBytesStore; +import org.apache.kafka.streams.state.internals.ChangeLoggingTimestampedWindowBytesStoreWithHeaders; +import org.apache.kafka.streams.state.internals.InMemoryWindowStore; +import org.apache.kafka.streams.state.internals.MeteredTimestampedWindowStore; +import org.apache.kafka.streams.state.internals.MeteredTimestampedWindowStoreWithHeaders; +import org.apache.kafka.streams.state.internals.WrappedStateStore; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.Mock; +import org.mockito.junit.jupiter.MockitoExtension; +import org.mockito.junit.jupiter.MockitoSettings; +import org.mockito.quality.Strictness; + +import java.time.Duration; + +import static java.util.Collections.emptyMap; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertInstanceOf; +import static org.mockito.Mockito.doReturn; +import static org.mockito.Mockito.lenient; +import static org.mockito.Mockito.when; + +@ExtendWith(MockitoExtension.class) +@MockitoSettings(strictness = Strictness.STRICT_STUBS) +public class WindowStoreMaterializerTest { + + private static final String STORE_PREFIX = "prefix"; + private static final String STORE_NAME = "name"; + private static final long WINDOW_SIZE_MS = 10000L; + + @Mock + private InternalNameProvider nameProvider; + @Mock + private WindowBytesStoreSupplier windowStoreSupplier; + @Mock + private StreamsConfig streamsConfig; + + private final WindowStore<Bytes, byte[]> innerWindowStore = + new InMemoryWindowStore(STORE_NAME, 60000L, WINDOW_SIZE_MS, true, "metricScope"); + + private Windows<?> windows; + private EmitStrategy emitStrategy; + + @BeforeEach + public void setUp() { + windows = TimeWindows.ofSizeWithNoGrace(Duration.ofMillis(WINDOW_SIZE_MS)); + emitStrategy = EmitStrategy.onWindowUpdate(); Review Comment: I think we also need to test `onWindowClose()`; what implies we need more changes as `onWindowClose()` uses a different store, for which we also need to a new header-aware "duplication" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
