aliehsaeedii commented on code in PR #21600:
URL: https://github.com/apache/kafka/pull/21600#discussion_r2888470661
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionStoreMaterializer.java:
##########
@@ -58,18 +59,20 @@ public SessionStoreMaterializer(
@Override
public StoreBuilder<?> builder() {
+ final DslStoreFormat storeFormat = dslStoreFormat() == null ?
DslStoreFormat.PLAIN : DslStoreFormat.HEADERS;
Review Comment:
>That we are doing this translation inside the "materializer" code is still
bugging me... It works, but it just doesn't feels righ
I structured it this way because it didn’t feel right to pass a string value
down to the lower layers and let them decide; sending null felt more
appropriate. If you think the other way, we can adjust it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
