lucasbru commented on code in PR #21655:
URL: https://github.com/apache/kafka/pull/21655#discussion_r2895646430
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TasksTupleWithEpochs.java:
##########
@@ -137,19 +141,16 @@ private static Map<String, Map<Integer, Integer>>
parseActiveTasksWithEpochs(
Map<Integer, Integer> partitionsWithEpochs = new HashMap<>();
- if (epochs != null && !epochs.isEmpty()) {
- if (epochs.size() != partitions.size()) {
- throw new IllegalStateException(
- "Assignment epochs must be provided for all
partitions. " +
- "Subtopology " + subtopologyId + " has " +
partitions.size() +
- " partitions but " + epochs.size() + " epochs"
- );
- }
-
+ if (epochs != null && epochs.size() == partitions.size()) {
for (int i = 0; i < partitions.size(); i++) {
partitionsWithEpochs.put(partitions.get(i), epochs.get(i));
}
} else {
+ if (epochs != null) {
+ log.error("Size of assignment epochs {} is not equal to
partitions {} for subtopology {}. " +
Review Comment:
Same comment about logging as in the other PR applies here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
